[parisc-linux] Re: [PATCH] space register 0 changes for hppa
Mon, 24 Feb 2003 12:48:55 +0000
On Mon, Feb 24, 2003 at 04:54:21PM +1030, Alan Modra wrote:
> ChangeLog entries shouldn't be sent as diffs. Write this one as
> * hppa-dis.c (print_insn_hppa <2 bit space register>): Do not print
> the space register when the value is zero.
> and put the reason for the change as a comment in the code if you feel
> you need some justification for the change.
OK. I'm just used to changelogs which're a little more verbose. I
don't think it really needs justifying.
> Did you run the binutils testsuite?
I hadn't... but I have now, and it doesn't introduce any failures.
"It's not Hollywood. War is real, war is primarily not about defeat or
victory, it is about death. I've seen thousands and thousands of dead bodies.
Do you think I want to have an academic debate on this subject?" -- Robert Fisk