[parisc-linux] Re: [PATCH] space register 0 changes for hppa
Alan Modra
amodra@bigpond.net.au
Mon, 24 Feb 2003 16:54:21 +1030
On Sun, Feb 23, 2003 at 06:58:47PM +0000, Matthew Wilcox wrote:
> + * hppa-dis.c: Do not emit a space register if the space register
> + field is 2 bits and the value is 0 as this is implicit addressing,
> + not use of space register 0.
Hi Matthew,
ChangeLog entries shouldn't be sent as diffs. Write this one as
* hppa-dis.c (print_insn_hppa <2 bit space register>): Do not print
the space register when the value is zero.
and put the reason for the change as a comment in the code if you feel
you need some justification for the change.
Did you run the binutils testsuite?
--
Alan Modra
IBM OzLabs - Linux Technology Centre