[parisc-linux] Re: [parisc-linux-cvs] linux grundler

[Grant Grundler]

On Sun, Feb 09, 2003 at 12:40:14AM -0700, John Marvin wrote:
> > o moved disable_sr_hash() from SMP to common code path so all
> > CPU's (including monarch) have this disabled.
> 
> Huh? You didn't seriously think the monarch still had sr hashing enabled
> did you?

sorry - I did.
I could not find where it was getting cleared for the monarch.

> Believe me, shared memory wouldn't work at all if that was the case.

ok.

> This change is wrong. init_per_cpu() is called too early for the monarch.

yup - it's before collect_boot_cpu_data(). :^(

> disable_sr_hashing() is called for the monarch in mm/init.c in
> setup_bootmem().

ugh. my bad.
I was only looking in arch/parisc/kernel/ since that's where it's defined
and was being used in the SMP case.

Can I move the disable_sr_hashing() call from setup_bootmem() to
before/after cache_init() in setup_arch()?

Please feel free to correct if you have time to muck with it.
If my damage is not backed out in the morning, I'll back it out then.

thanks for pointing out this stupidity,
grant