[parisc-linux] partial success with matroxfb

Andreas Seltenreich s_selten@informatik.uni-karlsruhe.de
Fri, 20 Sep 2002 17:54:30 +0200


Hallo Helge,
	
* Helge Deller <deller@gmx.de> [2002-09-20 09:25]:
> instead of 
> 
>  static inline unsigned int mga_readb(vaddr_t va, unsigned int offs) {
> +	return __raw_readb(va.vaddr + offs);
> - 	return readb(va.vaddr + offs);
>  }
> 
> I think you should use the
> 	fb_readXXX() and fb_writeXX()
> functions from include/video/fbcon.h which are automatically
> initialized correctly acording to the architecture.

I fear this would still break m68k because it is defined differently
in include/video/fbcon.h than in include/asm-m68k/io.h. matroxfb is
currently using the definition from io.h.

regards
andreas