[parisc-linux] pdc_add_valid

Grant Grundler grundler@puffin.external.hp.com
Fri, 05 Oct 2001 18:26:58 -0600


Matthew Wilcox wrote:
> 
> The pdc_add_valid function really annoys me.

So you want a sane wrapper around it.

> For the moment, I've put it in <asm/io.h>, since it is for I/O addresses.
> 
> +int valid_io_addr(unsigned long addr)
> +{
> +       return (pdc_add_valid(addr) == PDC_OK);
> +}

I prefer asm/io.h not depend on pdc.h.
Why not just add whatever wrapper to pdc.h?

> But maybe we should replace pdc_add_valid with valid_io_addr?
> Or a different function?  Suggestions appreciated.

sorry - no better ideas.

grant