[parisc-linux] Lasi harmony driver with mixer

[Matthew Wilcox]

Hi matthieu, i have a few comments.

On Tue, Jan 16, 2001 at 11:59:56PM +0100, Matthieu Delahaye wrote:
> +Bugs:
> +
> +1. Doesn't work on 715/old
> +
> +This driver doesn't work on 715/old machines, which include the 715/75.  The
> +chip used for this is technically called 'Vivace', which is identical to 
> +Harmony.  Should be easy to fix.  It has something to do with the way it is
> +reported by the inventory code.  The HPA is not that of Lasi or ASP so the
> +interrupts aren't registered properly.

afair, prumpf had his harmony driver working on the 715/scorpio.  perhaps
by looking at his source you could see what is missing?

> +int harmony_mixer_ioctl(struct inode * inode, struct file * file, unsigned int cmd, unsigned long arg)
> +{
> +  int val;
> +  int ret;
[...]

it'd be nice if you could rformat this to follow CodingStyle.

> +static struct file_operations harmony_mixer_fops =
> +{
> +	owner:	THIS_MODULE,
> +	llseek: NULL,
> +	read:   NULL,
> +	write:	NULL,
> +	poll: 	NULL,
> +	ioctl: 	harmony_mixer_ioctl,
> +	mmap:	NULL,
> +	open: 	NULL,
> +	release:NULL,
> +};

Don't initialise unused entries to NULL.  That's the point of using
the new syntax for struct initialisation -- that we don't need to list
unused ones.

-- 
Revolutions do not require corporate support.