[parisc-linux] rpc.lockd hangs (was Re: portmap deb)

[Matthew Wilcox]

On Mon, Apr 09, 2001 at 10:56:06AM +0100, Richard Hirst wrote:
> INLINE_SYSCALL wants a name, and an arg count, not a syscall number, eg:
> 
>   INLINE_SYSCALL(nfsservctl, 3, cmd, argp, resp);
> 
> so passing a syscall number in to syscall() doesn't work, and also
> syscall() won't know how many arguments there are to pass on to
> INLINE_SYSCALL.  Maybe we could just use '6' to get round that.

Yep, that's my thinking.

> Maybe we duplicate INLINE_SYSCALL in sysdeps/unix/sysv/linux/hppa/sysdep.h,
> call the new one INLINE_SYSCALL_NR, and replace 'SYS_ify(name)' with 'name'.
> Then have
> 
> int syscall(int nr, int arg1, int arg, int arg3, int arg4, int arg5, int arg6)
> {
>       return INLINE_SYSCALL_NR(nr, arg1, arg2, arg3, arg4, arg5, arg6);
> }

umm..

#define INLINE_SYSCALL(name, args...) INLINE_SYSCALL_NR(SYS_ify(name), args)

Otherwise, agreed.  This seems like a more robust approach than doing it
in assembler directly, and I don't believe it will be significantly less
efficient.  syscall() is clearly only used in exceptional cases anyway.

Since these packages have clearly never worked up till now, this seems
like an opportune point to change the sizes of these structures if that's
needed in order to get these syscalls implemented efficiently on 32 &
64 bit.

-- 
Revolutions do not require corporate support.