[parisc-linux-cvs] DIFF 2.6.0-test5-pa6 cleanup round 2

[Matthew Wilcox]

On Sun, Sep 14, 2003 at 12:42:27AM -0600, Grant Grundler wrote:
> Index: arch/parisc/kernel/time.c
> ===================================================================
> RCS file: /var/cvs/linux-2.6/arch/parisc/kernel/time.c,v
> retrieving revision 1.1
> diff -u -p -r1.1 time.c
> --- arch/parisc/kernel/time.c	29 Jul 2003 17:00:41 -0000	1.1
> +++ arch/parisc/kernel/time.c	14 Sep 2003 06:34:02 -0000
> @@ -48,7 +48,9 @@ static inline void
>  parisc_do_profile(struct pt_regs *regs)
>  {
>  	unsigned long pc = regs->iaoq[0];
> +#if 0
>  	extern unsigned long prof_cpu_mask;
> +#endif
>  	extern char _stext;
>  
>  	profile_hook(regs);

I seem to remember tausq asking that this warning not be fixed as it
was a reminder to him that he wasn't finished working on something yet.

> sym0: <896> rev 0x4 at pci 0000:00:0f.0 irq 129
> scsi_mode = 0, period = 500
> sym0: No NVRAM, ID 7, Fast-40, SE, parity checking
> sym0: suspicious SCSI data while resetting the BUS.
> sym0: dp1,d15-8,dp0,d7-0,rst,req,ack,bsy,sel,atn,msg,c/d,i/o = 0x4000100, expec0
> sym0: FATAL ERROR: CHECK SCSI BUS - CABLES, TERMINATION, DEVICE POWER etc.!
> sym0: giving up ...

hmm.. pdc_get_initiator must be broken then.  Here's what we do ...

sym_hipd.c:
sym_prepare_setting()
|-> parisc_setup_hcb()
    |-> pdc_get_initiator()
    |-> printk("scsi_mode = 0, period = 500");

pdc_get_initiator() fills in np->maxwide directly.

then, later, we do

sym_reset_scsi_bus()
|-> if (!np->maxwide) term &= 0x3ffff;
|-> term = 0x4000100

To be honest, I think pdc_get_initiator() is being hooked into the
driver too late.  I'd like to see it hooked in around sym_get_nvram().
I do have other changes planned around that area (eg ioremapping the
registers before calling sym_get_nvram()), but they shouldn't affect you.
If you wnt to reorganise how we do that bit, I'm very interested.

-- 
"It's not Hollywood.  War is real, war is primarily not about defeat or
victory, it is about death.  I've seen thousands and thousands of dead bodies.
Do you think I want to have an academic debate on this subject?" -- Robert Fisk