<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=iso-8859-1">
<META NAME="Generator" CONTENT="MS Exchange Server version 5.5.2653.12">
<TITLE>parisc-linux Digest, Vol 2, Issue 33</TITLE>
</HEAD>
<BODY>
<P><FONT SIZE=2>Send parisc-linux mailing list submissions to</FONT>
<BR> <FONT SIZE=2>parisc-linux@lists.parisc-linux.org</FONT>
</P>
<P><FONT SIZE=2>To subscribe or unsubscribe via the World Wide Web, visit</FONT>
<BR> <FONT SIZE=2><A HREF="http://lists.parisc-linux.org/mailman/listinfo/parisc-linux" TARGET="_blank">http://lists.parisc-linux.org/mailman/listinfo/parisc-linux</A></FONT>
<BR><FONT SIZE=2>or, via email, send a message with subject or body 'help' to</FONT>
<BR> <FONT SIZE=2>parisc-linux-request@lists.parisc-linux.org</FONT>
</P>
<P><FONT SIZE=2>You can reach the person managing the list at</FONT>
<BR> <FONT SIZE=2>parisc-linux-owner@lists.parisc-linux.org</FONT>
</P>
<P><FONT SIZE=2>When replying, please edit your Subject line so it is more specific</FONT>
<BR><FONT SIZE=2>than "Re: Contents of parisc-linux digest..."</FONT>
</P>
<BR>
<P><FONT SIZE=2>Today's Topics:</FONT>
</P>
<P><FONT SIZE=2> 1. Re: A fix for B2k and CONFIG_PDC_CONSOLE pb (Matthew Wilcox)</FONT>
<BR><FONT SIZE=2> 2. Re: A fix for B2k and CONFIG_PDC_CONSOLE pb (Joel Soete)</FONT>
<BR><FONT SIZE=2> 3. Re: A fix for B2k and CONFIG_PDC_CONSOLE pb (Joel Soete)</FONT>
</P>
<BR>
<P><FONT SIZE=2>----------------------------------------------------------------------</FONT>
</P>
<P><FONT SIZE=2>Message: 1</FONT>
<BR><FONT SIZE=2>Date: Mon, 26 Jan 2004 17:25:05 +0000</FONT>
<BR><FONT SIZE=2>From: Matthew Wilcox <willy@debian.org></FONT>
<BR><FONT SIZE=2>Subject: Re: [parisc-linux] A fix for B2k and CONFIG_PDC_CONSOLE pb</FONT>
<BR><FONT SIZE=2>To: Joel Soete <soete.joel@tiscali.be></FONT>
<BR><FONT SIZE=2>Cc: Christoph Plattner <christoph.plattner@gmx.at>, Grant Grundler</FONT>
<BR> <FONT SIZE=2><grundler@parisc-linux.org>, parisc-linux@lists.parisc-linux.org</FONT>
<BR><FONT SIZE=2>Message-ID: <20040126172505.GQ11844@parcelfarce.linux.theplanet.co.uk></FONT>
<BR><FONT SIZE=2>Content-Type: text/plain; charset=us-ascii</FONT>
</P>
<P><FONT SIZE=2>On Mon, Jan 26, 2004 at 06:00:53PM +0100, Joel Soete wrote:</FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> /* Bail if no console input device. */</FONT>
<BR><FONT SIZE=2>> - if (!PAGE0->mem_kbd.iodc_io)</FONT>
<BR><FONT SIZE=2>> + if ((PAGE0->mem_cons.cl_class != CL_DUPLEX) && !PAGE0->mem_kbd.iodc_io)</FONT>
<BR><FONT SIZE=2>> return 0;</FONT>
<BR><FONT SIZE=2>> </FONT>
<BR><FONT SIZE=2>> /* wait for a keyboard (rs232)-input */</FONT>
<BR><FONT SIZE=2>> spin_lock_irqsave(&pdc_lock, flags);</FONT>
<BR><FONT SIZE=2>> - real32_call(PAGE0->mem_kbd.iodc_io,</FONT>
<BR><FONT SIZE=2>> - (unsigned long)PAGE0->mem_kbd.hpa, ENTRY_IO_CIN,</FONT>
<BR><FONT SIZE=2>> - PAGE0->mem_kbd.spa, __pa(PAGE0->mem_kbd.dp.layers), </FONT>
<BR><FONT SIZE=2>> - __pa(iodc_retbuf), 0, __pa(iodc_dbuf), 1, 0);</FONT>
<BR><FONT SIZE=2>> + if (PAGE0->mem_cons.cl_class == CL_DUPLEX)</FONT>
</P>
<P><FONT SIZE=2>This doesn't make sense. PAGE0->mem_cons.cl_class has to be CL_DUPLEX</FONT>
<BR><FONT SIZE=2>otherwise the test above would have failed. Do you perhaps mean that &&</FONT>
<BR><FONT SIZE=2>above to be an || ? If so, this would all read better as ...</FONT>
</P>
<P> <FONT SIZE=2>/* wait for a keyboard (rs232)-input */</FONT>
<BR> <FONT SIZE=2>spin_lock_irqsave(&pdc_lock, flags);</FONT>
<BR> <FONT SIZE=2>if (PAGE0->mem_cons.cl_class == CL_DUPLEX) {</FONT>
</P>
<P> <FONT SIZE=2>real32_call(PAGE0->mem_cons.iodc_io,</FONT>
<BR> <FONT SIZE=2> (unsigned long)PAGE0->mem_cons.hpa, ENTRY_IO_CIN,</FONT>
<BR> <FONT SIZE=2> PAGE0->mem_cons.spa, __pa(PAGE0->mem_cons.dp.layers), </FONT>
<BR> <FONT SIZE=2> __pa(iodc_retbuf), 0, __pa(iodc_dbuf), 1, 0);</FONT>
<BR> <FONT SIZE=2>} else if (PAGE0->mem_kbd.iodc_io) {</FONT>
<BR> <FONT SIZE=2>real32_call(PAGE0->mem_kbd.iodc_io,</FONT>
<BR> <FONT SIZE=2> (unsigned long)PAGE0->mem_kbd.hpa, ENTRY_IO_CIN,</FONT>
<BR> <FONT SIZE=2> PAGE0->mem_kbd.spa, __pa(PAGE0->mem_kbd.dp.layers), </FONT>
<BR> <FONT SIZE=2> __pa(iodc_retbuf), 0, __pa(iodc_dbuf), 1, 0);</FONT>
<BR> <FONT SIZE=2>} else {</FONT>
<BR> <FONT SIZE=2>spin_unlock_irqrestore(&pdc_lock, flags);</FONT>
<BR> <FONT SIZE=2>return 0;</FONT>
<BR> <FONT SIZE=2>}</FONT>
</P>
<P><FONT SIZE=2>Slightly ugly to have two unlocks for the same lock, but that's better</FONT>
<BR><FONT SIZE=2>than duplicating the test. I haven't looked at the code, maybe we could</FONT>
<BR><FONT SIZE=2>use a goto instead.</FONT>
</P>
<P><FONT SIZE=2>-- </FONT>
<BR><FONT SIZE=2>"Next the statesmen will invent cheap lies, putting the blame upon </FONT>
<BR><FONT SIZE=2>the nation that is attacked, and every man will be glad of those</FONT>
<BR><FONT SIZE=2>conscience-soothing falsities, and will diligently study them, and refuse</FONT>
<BR><FONT SIZE=2>to examine any refutations of them; and thus he will by and by convince </FONT>
<BR><FONT SIZE=2>himself that the war is just, and will thank God for the better sleep </FONT>
<BR><FONT SIZE=2>he enjoys after this process of grotesque self-deception." -- Mark Twain</FONT>
</P>
<BR>
<P><FONT SIZE=2>------------------------------</FONT>
</P>
<P><FONT SIZE=2>Message: 2</FONT>
<BR><FONT SIZE=2>Date: Mon, 26 Jan 2004 19:20:26 +0100</FONT>
<BR><FONT SIZE=2>From: "Joel Soete" <soete.joel@tiscali.be></FONT>
<BR><FONT SIZE=2>Subject: Re: [parisc-linux] A fix for B2k and CONFIG_PDC_CONSOLE pb</FONT>
<BR><FONT SIZE=2>To: "Matthew Wilcox" <willy@debian.org></FONT>
<BR><FONT SIZE=2>Cc: Christoph Plattner <christoph.plattner@gmx.at>, Grant Grundler</FONT>
<BR> <FONT SIZE=2><grundler@parisc-linux.org>, parisc-linux@lists.parisc-linux.org</FONT>
<BR><FONT SIZE=2>Message-ID: <40153110000001C0@ocpmta2.freegates.net></FONT>
<BR><FONT SIZE=2>Content-Type: text/plain; charset="ISO-8859-1"</FONT>
</P>
<BR>
<BR>
<P><FONT SIZE=2>> + if ((PAGE0->mem_cons.cl_class != CL_DUPLEX) && !PAGE0->mem_kbd.iodc_io)</FONT>
<BR><FONT SIZE=2>> return 0;</FONT>
<BR><FONT SIZE=2>Right Matthew this case is nearly impossible (may be excepted if disconected</FONT>
<BR><FONT SIZE=2>the usb kbd during the boot), it would means that my pdc_console is not a</FONT>
<BR><FONT SIZE=2>serial one (ie graphic([01])) but no usb kdb found, so in that case pdc would</FONT>
<BR><FONT SIZE=2>switch console automaticaly to serial.</FONT>
</P>
<P><FONT SIZE=2>I would just still check the case when I have an usb kbd (I would have to</FONT>
<BR><FONT SIZE=2>recover one) but the pdc console is setup to serial port (eg no graphic screen</FONT>
<BR><FONT SIZE=2>available) just for an output screen without input kbd? </FONT>
</P>
<P><FONT SIZE=2>Thanks for your attention and remarks,</FONT>
<BR><FONT SIZE=2> Joel</FONT>
</P>
<BR>
<P><FONT SIZE=2>-------------------------------------------------------------------------</FONT>
<BR><FONT SIZE=2>Tiscali ADSL: 12 mois à 29,50 €/mois! L'Internet rapide, c'est pour tout</FONT>
<BR><FONT SIZE=2>le monde.</FONT>
<BR><FONT SIZE=2><A HREF="http://reg.tiscali.be/default.asp?lg=fr" TARGET="_blank">http://reg.tiscali.be/default.asp?lg=fr</A></FONT>
</P>
<BR>
<BR>
<BR>
<P><FONT SIZE=2>------------------------------</FONT>
</P>
<P><FONT SIZE=2>Message: 3</FONT>
<BR><FONT SIZE=2>Date: Mon, 26 Jan 2004 19:38:50 +0100</FONT>
<BR><FONT SIZE=2>From: "Joel Soete" <soete.joel@tiscali.be></FONT>
<BR><FONT SIZE=2>Subject: Re: [parisc-linux] A fix for B2k and CONFIG_PDC_CONSOLE pb</FONT>
<BR><FONT SIZE=2>To: "Matthew Wilcox" <willy@debian.org></FONT>
<BR><FONT SIZE=2>Cc: Christoph Plattner <christoph.plattner@gmx.at>, Grant Grundler</FONT>
<BR> <FONT SIZE=2><grundler@parisc-linux.org>, parisc-linux@lists.parisc-linux.org</FONT>
<BR><FONT SIZE=2>Message-ID: <4015311000000204@ocpmta2.freegates.net></FONT>
<BR><FONT SIZE=2>Content-Type: text/plain; charset="ISO-8859-1"</FONT>
</P>
<P><FONT SIZE=2>Sorry for auto reply, but I just find back the right kdb and:</FONT>
</P>
<P><FONT SIZE=2>>I would just still check the case when I have an usb kbd (I would have to</FONT>
<BR><FONT SIZE=2>>recover one) but the pdc console is setup to serial port (e</FONT>
<BR><FONT SIZE=2>>no graphic screen available) just for an output screen without input kbd?</FONT>
</P>
<BR>
<P><FONT SIZE=2>That case is also impossible, the console setup as serial_1 (eg) is always</FONT>
<BR><FONT SIZE=2>CL_DUPLEX :(</FONT>
</P>
<P><FONT SIZE=2>I will so review my patch.</FONT>
</P>
<P><FONT SIZE=2>Thanks for all,</FONT>
<BR><FONT SIZE=2> Joel</FONT>
</P>
<BR>
<P><FONT SIZE=2>-------------------------------------------------------------------------</FONT>
<BR><FONT SIZE=2>Tiscali ADSL: 12 mois à 29,50 €/mois! L'Internet rapide, c'est pour tout</FONT>
<BR><FONT SIZE=2>le monde.</FONT>
<BR><FONT SIZE=2><A HREF="http://reg.tiscali.be/default.asp?lg=fr" TARGET="_blank">http://reg.tiscali.be/default.asp?lg=fr</A></FONT>
</P>
<BR>
<BR>
<BR>
<P><FONT SIZE=2>------------------------------</FONT>
</P>
<P><FONT SIZE=2>_______________________________________________</FONT>
<BR><FONT SIZE=2>parisc-linux mailing list</FONT>
<BR><FONT SIZE=2>parisc-linux@lists.parisc-linux.org</FONT>
<BR><FONT SIZE=2><A HREF="http://lists.parisc-linux.org/mailman/listinfo/parisc-linux" TARGET="_blank">http://lists.parisc-linux.org/mailman/listinfo/parisc-linux</A></FONT>
</P>
<BR>
<P><FONT SIZE=2>End of parisc-linux Digest, Vol 2, Issue 33</FONT>
<BR><FONT SIZE=2>*******************************************</FONT>
</P>
</BODY>
</HTML>