No subject
Tue Nov 20 16:43:21 MST 2007
used, I decided to let the user allocate the buffer instead of using
the predefinded struct. The on-line docs indicated to me that only
the first 16 bytes are standard, after that the call was HVERSION dependent.
Since I could not determine what to use in all cases, I left it upto
the user. If it makes more sense to use a predefined struct for
better typecasting, etc ... I would be agreeable, I just didn't want to
break anything. :)
> - What are the guidelines for #ifdef __LP64__ vs CONFIG_PA20? You
> replaced __LP64__ with CONFIG_PA20 in some places but not others and I'm
> not clear on the difference.
The one instance I changed this was for the block TLB pdc calls. These
calls are not defined in the 2.0 arch so I changed the define to make
the more obvious. [Note: it also helped solve some compiling issues.]
> - In firmware.c, the "yes 'int', not 'long' -- IODC I/O is always 32-bit
> stuff" comment moved from pdc.h seems obsolete, or at least, I can't
> figure out what the 'int' refers to. I'd remove the "This means Cxxx
> boxes can't run wide kernels right now." comment, since CONFIG_PDC_NARROW
> addresses that issue.
This is true.... actually the Cxxx boxes won't run the 64-bit kernel now,
but it isn't a firmware issue, it is a driver issue. I'm working on this
and hopefully will have it solved soon. But, your point is well taken,
I should have removed the comment. Nice catch :)
> I attached a diff that fixes a few typos.
Thanks and much appreciated!
- Ryan
> Bjorn
More information about the parisc-linux
mailing list