[parisc-linux] need help with debian/hppa security build

[Matthew Wilcox]

On Mon, Sep 04, 2006 at 11:29:21AM -0600, dann frazier wrote:
> I'm in the process of preparing the next kernel security build, and am
> running into a build failure on hppa (and only hppa so far).
> 
> The build failure is caused by this patch:
>   svn cat svn://svn.debian.org/svn/kernel/dists/sarge-security/kernel/source/kernel-source-2.6.8-2.6.8/debian/patches/kfree_skb-race.dpatch
> 
> I rsync'd a build tree over to parisc-linux.org - ~dannf/build-32-smp,
> just make a copy & run 'make vmlinux' to reproduce:
> 
> make[2]: Entering directory `/tmp/kernel-image-2.6.8-hppa-2.6.8/build-32-smp'
> make[3]: `arch/parisc/kernel/asm-offsets.s' is up to date.
>   CC      init/main.o
> In file included from include/linux/security.h:34,
>                  from init/main.c:35:
> include/linux/skbuff.h: In function `kfree_skb':
> include/linux/skbuff.h:359: error: syntax error before "else"

The problem lies in asm-parisc/system.h:

#define mb()            __asm__ __volatile__("":::"memory");    /* barrier() */

Take the ; off the end of that line and everything should be OK.