[parisc-linux] [PATCH] hppa-linux-gas binutils patch

Carlos O'Donell carlos at systemhalted.org
Sun Nov 26 15:06:04 MST 2006


On 11/23/06, Helge Deller <deller at gmx.de> wrote:
> hppa-linux-gnu-gas only allows one type of ".equ" pseudo-op syntax:
> symbol:         .equ value
>
> The following patch allows hppa-gas to understand
>                         .equ symbol,value
> as well, which seems to be pretty standard for other gas-targets as well.
>
> I didn't found any problems yet with this patch, and it allows even the
> src/binutils/testsuite/binutils-all/localize-hidden-1.s
> gas test  to compile.
>
> Comments ?
> If OK, would somebody with write-access to binutils submit it upstream ?

Helge,

Thanks Helge! Out of curiosity do you have a copyright assignment for
binutils? If not, then that is OK, I can submit your patch upstream
and check it in aswell.

One good deed deserves another, could you provide a patch to update
the documentation aswell?

The GAS manual says:
---
.equ symbol, expression
This directive sets the value of symbol to expression. It is
synonymous with `.set'; see section .set symbol, expression.
The syntax for equ on the HPPA is `symbol .equ expression'.
---

This should be updated.

Have you considered the implications of your patch to porting HPUX assembly?
Does the HPUX assembler have an .equ directive? Dave can probably
answer that so I'll CC him.

---
label .reg expr
    Synonym for .equ; define label with the absolute expression expr
as its value.
---

In summary... if you provide a documentation patch I'll test this and
submit upstream. When upstreams gives the green flag I'll check this
into binutils head.

Cheers,
Carlos.



More information about the parisc-linux mailing list