[parisc-linux] suppress led task for KittyHawk's LCD

[Guy Martin]

Hi Helge,

This can't work. If you don't call register_led_driver(), led_func_ptr and led_type stay NULL and lcd_print() never prints anything.
You can change lcd_print() not to check led_func_ptr but I fear something may break if the device is not initialized :)

Maybe we could use static int initialized defined in register_led_driver and make it global to check if the device is ready or not.

  Guy


On Sun, 12 Nov 2006 15:04:38 +0100
Helge Deller <deller at gmx.de> wrote:

> Hi Guy,
> 
> On Sunday 12 November 2006 01:45, Guy Martin wrote:
> > I've noticed that the LCD on my K410 is filled at a constant rate with black characters.
> > After some investigation, it looked like the code updating the led status was filling the LCD.
> ....
> 
> instead of adding:
> +               no_led = 1;     /* no led support on KittyHawk */
>                 goto found;     /* use the preinitialized values of lcd_info */
> 
> did you tried to comment out the "goto found" ?
> 
> Helge