[parisc-linux] Re: update mman.h in latest glibc cvs

[Mike Frysinger]

On Friday 25 August 2006 16:01, Carlos O'Donell wrote:
> 1. You need a ChangeLog.

indeed ... i wanted to see if the patch was correct first as writing ChangeLog 
entries is boring ;)

> 2. You will need FSF assignments if you don't already have them for GLIBC.

i dont have in place specifically for glibc, ive just contributed my previous 
things as "small" and/or "obvious" ... i can simply release into the public 
domain; all that matters to me is that things get fixed

> The following is a bug.
> +# define MAP_ANON	MAP_ANONYMOUS
> +# define MAP_ANONYMOUS	0x10		/* don't use a file */

yes, that should be reversed

> Please avoid superflous style changes.

it isnt superfluous, it is the "GNU standard" and the way all other arch 
mman.h headers are done ... so while i personally consider the GNU coding 
standard complete garbage, glibc is a GNU project and adheres pretty rigidly 
to the GNU coding standard

> Are you sure nothing uses these?
> -#define MAP_VARIABLE	0
> -# define MADV_VPS_PURGE	  6	/* Purge pages from VM page cache */
> -# define MADV_VPS_INHERIT 7	/* Inherit parents page size */

i was syncing to other architectures ... but since parisc is the only one (in 
the kernel headers) that defines these three, i guess it's appropriate to 
keep them for parisc
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: not available
Url : http://lists.parisc-linux.org/pipermail/parisc-linux/attachments/20060825/011da3ad/attachment.pgp