[parisc-linux] Re:[parisc-linux-cvs] linux-2.6 kyle

[Kyle McMartin]

On Tue, Aug 01, 2006 at 09:31:01AM -0600, Matthew Wilcox wrote:
> How can r *possibly* be NULL?  You've taken the *address* of an offset
> from t->thread.  Mind you, I think gcc is smart enough to delete this
> useless test these days, but there's still no excuse for writing it.
> 

Indeed.

> > +       struct pt_regs r2 = *r;
> 
> Is this really wise?  pt_regs is *huge* -- 472 bytes on 32-bit and 688
> bytes on 64-bit.
> 

Not so bad when you consider we have 16K stack. IIRC, I committed
a change to traps.c to not kmalloc but instead put pt_regs on the
stack. If x86-64 can get by with an 8K stack, I think we're fine
with a 16K stack on 64bit. (Though I really want 8K or 16K page
size...)

Cheers,
	Kyle M.