[fuse-devel] Re: [parisc-linux] [PATCH] Fixs to work on ARM and PARIC platforms.

James Bottomley James.Bottomley at SteelEye.com
Sun Apr 2 08:09:20 MDT 2006


On Sun, 2006-04-02 at 10:45 +0200, Miklos Szeredi wrote:
> I'm confused.  What was the exact reason for having a separate
> function for anon pages?  Wouldn't unifying the functionality of
> flush_dcache_page() and flush_anon_page() make more sense?

No because flush_dcache_page() is designed for filesystems, which should
never see anonymous pages.

> Otherwise sparc and ppc would have to check PageAnon() from both
> flush_dcache_page() and flush_anon_page() and call a common function,
> which seems to just complicate things without any gain.

I don't think what you propose is desirable or possible:
flush_dcache_pages() is designed not to have to flush them (it can't
actually because it can't find them properly) but it may flush them by
accident if they get swept up into the implementation.  Sparc and PPC
are CAM flushing implementations, so I suspect the cache just needs to
be asked to flush a single physical address and it will find all the
virtual aliases and flush them (including the anonymous pages).

James





More information about the parisc-linux mailing list