[parisc-linux] Re: zalon/ncr53c720 crashes K460 (parisc port) on bootup.

[James Bottomley]

On Sat, 2003-09-27 at 13:37, Matthew Wilcox wrote:
> On Sat, Sep 27, 2003 at 10:45:50AM -0500, James Bottomley wrote:
> > This should fix the panic, but it simply detaches correctly.
> 
> We both missed it.  This is why it's panicing:
> 
>         host = ncr_attach(&zalon7xx_template, unit, &device);
>         if (!host)
>                 goto fail;
>  fail:
>         ncr53c8xx_release(host);
>         return error;
> 
> ie we're calling ncr53c8xx_release(NULL) so both your & my patch fail
> to fix the problem.  This looks best to me:

No, I fixed that...that was changed to goto out; in my patch, and out
was just before the return (i.e. no longer do the release).

James