[parisc-linux] Problem with SCSI_IOCTL_GET_PCI ioctl

Matthew Wilcox willy@debian.org
Mon, 22 Sep 2003 18:58:16 +0100


On Mon, Sep 22, 2003 at 10:43:00PM +0530, SUDARSANAN,RANJITH (HP-India,ex2) wrote:
> I traced this error down to ioctl32.c line no. ~ 3056 to 3063
> 
> /* Big S */
> COMPATIBLE_IOCTL(SCSI_IOCTL_GET_IDLUN)
> COMPATIBLE_IOCTL(SCSI_IOCTL_DOORLOCK)
> COMPATIBLE_IOCTL(SCSI_IOCTL_DOORUNLOCK)
> COMPATIBLE_IOCTL(SCSI_IOCTL_TEST_UNIT_READY)
> COMPATIBLE_IOCTL(SCSI_IOCTL_TAGGED_ENABLE)
> COMPATIBLE_IOCTL(SCSI_IOCTL_TAGGED_DISABLE)
> COMPATIBLE_IOCTL(SCSI_IOCTL_GET_BUS_NUMBER)
> COMPATIBLE_IOCTL(SCSI_IOCTL_SEND_COMMAND)
> COMPATIBLE_IOCTL(SCSI_IOCTL_GET_PCI) 		/*This entry is missing in
> the ioctl translation table*/
> /* Big V */
> COMPATIBLE_IOCTL(VT_SETMODE)
> COMPATIBLE_IOCTL(VT_GETMODE)
> COMPATIBLE_IOCTL(VT_GETSTATE)
> COMPATIBLE_IOCTL(VT_OPENQRY)
> 
> The above entry fixed the problem. I am surprised that ioctls code wasn't
> tested. When I see the code. This seems to be the last ioctl which was
> added.
> 
> I am not sure if I should post this here, please let me know if I am wrong.

Right place to post it, right fix.  Patch committed as 2.4.22-pa8.
Could you send it in the form of a unified diff next time?  eg:

cvs diff -u arch/parisc/kernel/ioctl32.c

Thanks.

-- 
"It's not Hollywood.  War is real, war is primarily not about defeat or
victory, it is about death.  I've seen thousands and thousands of dead bodies.
Do you think I want to have an academic debate on this subject?" -- Robert Fisk