[parisc-linux] Re: [PATCH] linuxthreads for hppa (1/3)

Carlos O'Donell carlos@baldric.uwo.ca
Wed, 15 Oct 2003 01:40:45 -0400


On Tue, Oct 14, 2003 at 10:13:24PM -0700, Ulrich Drepper wrote:
> 
> I think I've asked this before:
> 
> > 	Use __LT_INITIALIZER_NOT_ZERO instead of __LT_SPINLOCK_INIT.
> 
> Why?  No unnecessary changes.

__LT_SPINLOCK_INIT is the value of the structure and used for
initialization e.g. { 1, 1, 1, 1 }. It can no longer be used in a macro
evaluation like "#if __LT_SPINLOCK_INIT". Instead the other macros was
added.
 
> No unnecessary changes.  Leave the code you're not using alone.
> And again.

I made the mistake of adding my STACK_GROWS_UP fixes to this patch set.
If you note I have submitted a "Round 2" set of patches that remove
these changes.

Cheeers,
Carlos.