[parisc-linux] byte swapping redux

[Matthew Wilcox]

On Sun, Jun 29, 2003 at 12:14:15PM -0600, Grant Grundler wrote:
> Hi all,
> 
> Can someone explain why include/asm-parisc/byteorder.h uses the following?
> 
> #if !defined(__STRICT_ANSI__) || defined(__KERNEL__)
> #  define __BYTEORDER_HAS_U64__
> #  define __SWAB_64_THRU_32__
> #endif

Protection against userspace inclusion.  Which shouldn't be happening
of course, but some userspace programs are crap.

> vs include/asm-sparc64/byeorder.h:
> #define __BYTEORDER_HAS_U64__
> 
> I'm pretty sure we don't want __SWAB_64_THRU_32__ defined.
> PA-RISC version of ___arch__swab64() is appropriately defined for
> both 32 and 64-bit compiles.

Take it out then; if it works, commit it (to 2.5 anyway).

-- 
"It's not Hollywood.  War is real, war is primarily not about defeat or
victory, it is about death.  I've seen thousands and thousands of dead bodies.
Do you think I want to have an academic debate on this subject?" -- Robert Fisk