[parisc-linux] proposed changes to dino.c

[Thomas Bogendoerfer]

On Fri, Dec 12, 2003 at 12:48:38AM -0700, Grant Grundler wrote:
> On Wed, Dec 10, 2003 at 04:54:24PM -0500, James Bottomley wrote:
> > +/* The alignment contraints for PCI bridges under dino */
> > +#define DINO_BRIDGE_ALIGN 0x100000
> 
> hrmm...I was expecting this to be defined in include/linux/pci.h
> but it's not. "pbus_size_mem()" seems to take care of this
> in the drivers/pci generic code.
> 
> > +		/* null out the ROM resource if there is one (we don't
> > +		 * care about an expansion rom on parisc, since it
> > +		 * usually contains (x86) bios code) */
> > +		dev->resource[PCI_ROM_RESOURCE].flags = 0;
> > +		dev->resource[PCI_ROM_RESOURCE].start = 0;
> > +		dev->resource[PCI_ROM_RESOURCE].end = 0;
> 
> I just realized some drivers may need to access data (not code)
> in the ROM. I'm not aware of any but I don't want to under
> estimate how creative people can get. Just something to beware
> when bringing up new cards.

doesn't this also break PCI Vis-EG and FX cards setup ? On these
cards the ROM contains PARISC firmware, which we need.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessary a
good idea.                                 [ Alexander Viro on linux-kernel ]