[parisc-linux] Proposed changes to flush_dcache_page to fix our shared ro mapping problem

[James Bottomley]

--=-PE2Uwl0LkbJxW+65VgYL
Content-Type: text/plain
Content-Transfer-Encoding: 7bit

The attached should do it

(plus the fix to preserve the VM_MAYSHARE flag on remap).

I've verified that this fixes the glibc tst-mmap-eofsync test.

James


--=-PE2Uwl0LkbJxW+65VgYL
Content-Disposition: inline; filename=tmp.diff
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; name=tmp.diff; charset=ISO-8859-1

=3D=3D=3D=3D=3D arch/parisc/kernel/cache.c 1.4 vs edited =3D=3D=3D=3D=3D
--- 1.4/arch/parisc/kernel/cache.c	Sat Mar  8 14:01:30 2003
+++ edited/arch/parisc/kernel/cache.c	Sat Aug 23 11:22:22 2003
@@ -232,7 +232,8 @@
=20
 	if (!page->mapping)
 		return;
-
+	/* check shared list first if it's not empty...it's usually
+	 * the shortest */
 	list_for_each(l, &page->mapping->i_mmap_shared) {
 		struct vm_area_struct *mpnt;
 		unsigned long off;
@@ -243,6 +244,33 @@
 		 * If this VMA is not in our MM, we can ignore it.
 		 */
 		if (mpnt->vm_mm !=3D mm)
+			continue;
+
+		if (page->index < mpnt->vm_pgoff)
+			continue;
+
+		off =3D page->index - mpnt->vm_pgoff;
+		if (off >=3D (mpnt->vm_end - mpnt->vm_start) >> PAGE_SHIFT)
+			continue;
+
+		flush_cache_page(mpnt, mpnt->vm_start + (off << PAGE_SHIFT));
+
+		/* All user shared mappings should be equivalently mapped,
+		 * so once we've flushed one we should be ok
+		 */
+		return;
+	}
+
+	/* then check private mapping list for read only shared mappings
+	 * which are flagged by VM_MAYSHARE */
+	list_for_each(l, &page->mapping->i_mmap) {
+		struct vm_area_struct *mpnt;
+		unsigned long off;
+
+		mpnt =3D list_entry(l, struct vm_area_struct, shared);
+
+
+		if (mpnt->vm_mm !=3D mm || !(mpnt->vm_flags & VM_MAYSHARE))
 			continue;
=20
 		if (page->index < mpnt->vm_pgoff)

--=-PE2Uwl0LkbJxW+65VgYL--