[parisc-linux] Re: [parisc-linux-cvs] Serial MUX driver update.

[Matthew Wilcox]

On Sun, Aug 25, 2002 at 09:30:35PM -0600, Ryan Bradetich wrote:
> Update to the serial mux driver.
>  static struct parisc_device_id mux_tbl[] = {
>  	{ HPHW_A_DIRECT, HVERSION_REV_ANY_ID, 0x015, 0x0000D }, /* Eole CAP/MUX */
> +	{ HPHW_A_DIRECT, HVERSION_REV_ANY_ID, 0x044, 0x0000D }, /* Sahp Baat Kiuh AP/MUX */
>  	{ 0, }
>  };

May I suggest:

static struct parisc_device_id mux_tbl[] = {
	{ HPHW_A_DIRECT, HVERSION_REV_ANY_ID, HVERSION_ANY_ID, 0x0000D }, 
	{ 0, }
};

since this driver should work for all MUXes, not just Eole & SBK.

By and large, everyone should have HVERSION_ANY_ID in their
parisc_device_id tables.  There's some exceptions (ccio, astro, elroy,
dino, serial), but most drivers shouldn't need to discriminate on
hversion.

-- 
Revolutions do not require corporate support.