[parisc-linux] ide_intr() code review

Grant Grundler grundler@puffin.external.hp.com
Thu, 18 Oct 2001 22:47:27 -0600


Hey, 
trivial thing that's not really a bug.

linux/spinlock.h:#define spin_lock_irqsave(lock, flags)               do { local_irq_save(flags);       spin_lock(lock); } while (0)

asm-parisc/system.h:#define local_irq_save(x) \
        __asm__ __volatile__("rsm %1,%0" : "=r" (x) :"i" (PSW_I) : "memory" )

/*
 * entry point for all interrupts, caller does __cli() for us
 */
void ide_intr (int irq, void *dev_id, struct pt_regs *regs)
{ 
...
        spin_lock_irqsave(&io_request_lock, flags);


is __cli() being done twice?

It just seems wrong to be calling spin_lock_irqsave() from
the interrupt handler.

grant