[parisc-linux] Re: E55 status

[Matthew Wilcox]

Let's try a quick audit...

On Mon, Nov 19, 2001 at 11:42:29PM +0100, Christoph Plattner wrote:
> cvs server: Diffing .
> cvs server: Diffing Documentation

could you use the cvsrc distributed as part of build-tools?  it removes
this extra verbiage...

> +	/* wait for a keyboard (rs232)-input */
> +	do {
> +		unsigned long flags;
> +
> +		save_flags(flags);
> +		cli();
> +		status = real32_call(PAGE0->mem_kbd.iodc_io,
> +			(unsigned long)PAGE0->mem_kbd.hpa, ENTRY_IO_CIN,
> +			PAGE0->mem_kbd.spa, __pa(PAGE0->mem_kbd.dp.layers),
> +			__pa(iodc_retbuf), 0, __pa(iodc_dbuf), 1, 0);
> +		restore_flags(flags);
> +		ch = *iodc_dbuf;	/* save the character directly to ch */
> +	} while (0) ;                   /* once !! */

please use spin_lock_irqsave/restore instead.

> #ifdef SERIAL_INLINE
> #define _INLINE_ inline
> #else
> #define _INLINE_
> #endif

i hate this.  all examples of this have been removed from our tree afaik..

have to go out now... back later.

-- 
Revolutions do not require corporate support.