[parisc-linux] Additional PDC cleanups

[Matthew Wilcox]

On Sat, Mar 24, 2001 at 03:44:19PM -0700, Ryan Bradetich wrote:
> My first thoughts were to make the STI_CALL function look like this:
> 
> #define STI_CALL(func, flags, inptr, outptr, glob_cfg) \
> 	({	 						\
> 		pdc_sti_call( func, (unsigned long)STI_PTR(flags), \
> 				    STI_PTR(inptr), STI_PTR(outptr), \
> 				    glob_cfg); \
> 	})
> 
> and define the pdc_sti_call in firmware.c.  Anyone have a different
> approach that would make more sense? 

Makes sense.  you might want to remove the cast and do it inside
pdc_sti_call.  every time i look at the sti code, i have to resist the
urge to rip it into tiny pieces and redo it :-)

> +/*
> + * pdc_putc:
> + * Console character print using IODC.
> + *
> + * Note that only these special chars are architected for console IODC io:
> + * BEL, BS, CR, and LF. Others are passed through.
> + * Since the HP console requires CR+LF to perform a 'newline', we translate
> + * "\n" to "\r\n".
> + */

This is so close to being kernel-doc it seems foolish not to go the
whole hog.

/**
 * iodc_putc - Console character print using IODC.
 * @c: the character to output.
 * 
 * Note that only these special chars are architected for console IODC io:
 * BEL, BS, CR, and LF. Others are passed through.
 * Since the HP console requires CR+LF to perform a 'newline', we translate
 * "\n" to "\r\n".
 */

-- 
Revolutions do not require corporate support.