[parisc-linux] Unregister driver patch

Grant Grundler grundler@cup.hp.com
Sun, 25 Feb 2001 20:30:55 -0800


Matthieu Delahaye wrote:
> I think holidays aren't good for me.

hmmm...maybe not. ;^)

I'll apply the patch tomorrow barring major objections.
The patch looks good to me (with one nit noted below).
Thanks!


> -			if (device->managed)			continue;
> +			if ((int)device->driver) continue;

I'll change this to:
		if (NULL != device->driver) continue;

device->driver is a pointer and should certainly not be cast to an int
in this case. For 64-bit, we will loose the upper half of the address
and we want to test the entire address. Even if it worked, I wouldn't
want to risk it not working in the future.

grant

Grant Grundler
parisc-linux {PCI|IOMMU|SMP} hacker
+1.408.447.7253