[parisc-linux] [PATCH] PDC cleanup and encapsulation

[Matthew Wilcox]

On Wed, Apr 04, 2001 at 09:57:25AM -0700, Bjorn Helgaas wrote:
> - What are the guidelines for #ifdef __LP64__ vs CONFIG_PA20?  You 
> replaced __LP64__ with CONFIG_PA20 in some places but not others and I'm 
> not clear on the difference.

Not all PA-2.0 processors are run in 64-bit mode.  For example, a C3000
can be run in either 32 or 64 bit mode.  At compile-time you can choose
to optimise for a particular processor (and risk it not working on
other machines).

> - In firmware.c, the "yes 'int', not 'long' -- IODC I/O is always 32-bit 
> stuff" comment moved from pdc.h seems obsolete, or at least, I can't 
> figure out what the 'int' refers to.  I'd remove the "This means Cxxx 
> boxes can't run wide kernels right now." comment, since CONFIG_PDC_NARROW 
> addresses that issue.

yup, some of the comments are definitely stale.

see linus' comments about disliking comments because of this issue :-)

-- 
Revolutions do not require corporate support.