[parisc-linux] Code Readability

Philipp Rumpf prumpf@suse.de
Sat, 23 Oct 1999 02:33:18 +0200


As there already seems to be a discussion going on about this, here's a list
of things I would change in order to save developers time;  this is obviously
biased towards developers who spent some time doing this, not towards those
new to the code.

 - get rid of the cvs $Log$s.  Not only do they tend to get longer than the
code in question, they also seem to be downright boring to me.  The only
information you need in the common case is "who was the last one to modify
this file" which $Id$ does just fine.

 - use #if 0 (or #ifdef SOMETHING) instead of "/*" to comment out sections of
code more than one line long.

 - try to avoid using C++-style "//" line comments, or any comment style except
the usual one, which is
	line; /* line comment */

/*
 * long comment
 * ...
 */

 - if you use #ifdef SOMETHING_DEBUG to conditionally compile sanity checks,
put an #undef SOMETHING_DEBUG or #define SOMETHING_DEBUG at the top of the
file.  If it is a header file, you don't want to run into problems because
#define SOMETHING_DEBUG is in some .c files and not in others.

 - stay with standard linux names.  We're pretty good at that.

 - look at Documentation/CodingStyle once in a while, especially Chapter 4

	Philipp Rumpf

X-From-Line: hppa-linux@thepuffingroup.com  Sun Feb 28 09:38:14 1999
Return-Path: <hppa-linux@thepuffingroup.com>
Received: from merlin.pcj.primenet.com (pcj@merlin.pcj.primenet.com [192.168.111.10])
	by merlin.pcj.primenet.com (8.8.7/8.8.7) with ESMTP id JAA21816
	for <pcj@merlin.pcj.primenet.com>; Sun, 28 Feb 1999 09:38:09 -0800
Resent-From: hppa-linux@thepuffingroup.com
Received: from pop.primenet.com
	by merlin.pcj.primenet.com (fetchmail-4.4.7 POP3)
	for <pcj/merlin.pcj.primenet.com> (single-drop); Sun, 28 Feb 1999 09:38:13 PST
Received: from smtp04.primenet.com (daemon@smtp04.primenet.com [206.165.6.134])
	by primenet.com (8.8.8/8.8.5) with ESMTP id KAA15878
	for <pcj@smtp-local.primenet.com>; Sun, 28 Feb 1999 10:25:42 -0700 (MST)
Received: (from daemon@localhost)
	by smtp04.primenet.com (8.8.8/8.8.8) id KAA16656
	for <pcj@primenet.com>; Sun, 28 Feb 1999 10:54:14 -0700 (MST)
Received: from SOD.RES.CMU.EDU(128.2.91.30)
 via SMTP by smtp04.primenet.com, id smtpd016630; Sun Feb 28 10:54:08 1999
Received: (from listserv@localhost)
	by sod.res.cmu.edu (8.8.7/8.8.7) id MAA27269;
	Sun, 28 Feb 1999 12:05:42 -0500
Resent-Date: Sun, 28 Feb 1999 12:05:42 -0500
Delivered-To: thepuffi-hppa-linux@thepuffingroup.com
Message-Id: <199902281700.JAA18341@milano.cup.hp.com>
X-Authentication-Warning: milano.cup.hp.com: grundler@localhost [127.0.0.1] didn't use HELO protocol
To: hppa-linux@thepuffingroup.com
Subject: Re: [hppa-linux] Another bootstrap test 
In-reply-to: Your message of "Sat, 27 Feb 1999 02:10:25 PST."
             <AB06BBFD8AFBD111B07600805FCB119224240A@EXCHANGE.aubi.de> 
Date: Sun, 28 Feb 1999 09:00:34 -0800
From: Grant Grundler <grundler@cup.hp.com>
Resent-Message-ID: <"01Ldi3.0._f6.cTNss"@sod.res.cmu.edu>
Reply-To: hppa-linux@thepuffingroup.com
X-Mailing-List: <hppa-linux@thepuffingroup.com> archive/latest/131
X-Loop: hppa-linux@thepuffingroup.com
Precedence: list
Resent-Sender: hppa-linux-request@thepuffingroup.com
X-UIDL: 3284d02c8d7154cb32647b81f9da6f02
Lines: 31
Xref: merlin.pcj.primenet.com palinux:102


Markus Doehr wrote:
...
> We have some HP machines around here:
> 
> 	A 9000/715
> 	A 9000/778
> 	B 9000/375
> 
> On moday I'll speak to the admin if I could do some testing in the evening,
> when the machines are not needed any more. Sorry for silly asking, but is
> the 'C160' the only model currently "supported" or will our machines
> probably work too?

The 778 listed is most likely a B132L  - little brother to the C160.
Type "model" at the command line and you should get back something
like:
9000/778/B132L

I'm afraid the 9000/375 is a Motarola based workstation and not PA-RISC.

grant

Grant Grundler
Enterprise Systems Technology Lab
+1.408.447.7253

-------------------------------------------------------------------------
To unsubscribe: send e-mail to hppa-linux-request@thepuffingroup.com with
`unsubscribe' as the subject.