[parisc-linux-cvs] sba_iommu cut/paste err

Grant Grundler grundler at parisc-linux.org
Wed Jan 12 09:52:06 MST 2005


On Tue, Jan 11, 2005 at 08:59:14PM -0700, Matthew Wilcox wrote:
> Log message:
> 	Fix all ioremap abuse noticed by CONFIG_DEBUG_IOREMAP on an N4000.
> 	Also some other small tidyups that Grant will probably notice a
> 	problem with ;-)

*sigh*. I was hopeful I wouldn't just to say "Nope, not this time".
I even made it all the through until nearly the end of sba_iommu.c. :^)

> http://cvs.parisc-linux.org/linux-2.6/drivers/parisc/sba_iommu.c.diff?cvsroot=&r1=1.25&r2=1.26

The chunk starting at Line 1676 vs 1664 uses ASTRO_IOC_OFFSET in the old
and PLUTO_IOC_OFFSET in the new. That can't be right and looks like
a cut/paste error.

The rest looks good!

thanks!
grant


More information about the parisc-linux-cvs mailing list