[parisc-linux-cvs] linux-2.6 willy

[Grant Grundler]

On Wed, Oct 27, 2004 at 09:36:56PM +0100, Matthew Wilcox wrote:
> Here's what I did.  As always, code speaks better than words about how
> something is/should/could be done:

yup

> -	/* convert Bus speed in Mhz to period (in 1/10 ns) */
> -	switch (pdc_result[1]) {
...
> -		case 80:  *period = 125; break;

> +	switch (pdc_result[1]) {
...
> +		case 40: initiator->factor = 10; break;
> +		default: initiator->factor = -1; break;
> +	}

"case 80" is missing?
ISTR that should be:
	case 80: initiator->factor = 9; break;

...
>  	if	(period <= 250)		np->minsync = 10;
>  	else if	(period <= 303)		np->minsync = 11;

ISTR also once reworking this to include a "period <= 125" case.
Isn't that necessary for U160 support or is U160 broken?

> Index: drivers/scsi/sym53c8xx_2/sym_nvram.c
...
> +	case SYM_PARISC_PDC:
> +		if (nvram->data.parisc.host_id != -1)
> +			np->myaddr = nvram->data.parisc.host_id;
...

Yeah - this is makes sense.


thanks,
grant