[parisc-linux-cvs] linux-2.6 tausq

[Michael Wood]

On Mon, Oct 04, 2004 at 12:15:13PM -0700, Randolph Chung wrote:
[snip]
> first pass at running sparse on the parisc tree.... need to
[snip]
> -			return 0xffffffff00000000 | (u32)address;
> +			return 0xffffffff00000000UL | (u32)address;
[snip]

Wouldn't it make sense to make the above and the stuff below
consistent?  (i.e. both use UL or both use ul?)

>  static uint64_t perf_bitmasks[] = {
> -	0x0000000000000000,     /* first dbl word must be zero */
> -	0xfdffe00000000000,     /* RDR0 bitmask */
> -	0x003f000000000000,     /* RDR1 bitmask */
> -	0x00ffffffffffffff,     /* RDR20-RDR21 bitmask (152 bits) */
> -	0xffffffffffffffff,
> -	0xfffffffc00000000,
> -	0xffffffffffffffff,     /* RDR22-RDR23 bitmask (233 bits) */
> -	0xffffffffffffffff,
> -	0xfffffffffffffffc,
> -	0xff00000000000000
> +	0x0000000000000000ul,     /* first dbl word must be zero */
> +	0xfdffe00000000000ul,     /* RDR0 bitmask */
> +	0x003f000000000000ul,     /* RDR1 bitmask */
> +	0x00fffffffffffffful,     /* RDR20-RDR21 bitmask (152 bits) */
> +	0xfffffffffffffffful,
> +	0xfffffffc00000000ul,
> +	0xfffffffffffffffful,     /* RDR22-RDR23 bitmask (233 bits) */
> +	0xfffffffffffffffful,
> +	0xfffffffffffffffcul,
> +	0xff00000000000000ul
>  };
[snip]

michael at marmite:~/src/parisc/linux-2.6$ find ./ -type f -name '*.[chS]' -print0
| xargs -0 grep -l '\<[0-9a-fA-F][0-9a-fA-F]*ul\>' | wc -l
41
michael at marmite:~/src/parisc/linux-2.6$ find ./ -type f -name '*.[chS]' -print0
| xargs -0 grep -l '\<[0-9a-fA-F][0-9a-fA-F]*UL\>' | wc -l
605

-- 
Michael Wood <mwood at icts.uct.ac.za>