[parisc-linux-cvs] Re: DIFF 2.6.7-pa10 iosapic/debug/rp3440 boot

[Grant Grundler]

On Sat, Jul 10, 2004 at 09:10:25AM -0500, James Bottomley wrote:
> On Sat, 2004-07-10 at 03:01, Grant Grundler wrote:
> >  void pdc_emergency_unlock(void)
> >  {
> > -        spin_unlock(&pdc_lock);
> > +        spin_trylock(&pdc_lock);  /* get pdc_lock before spinlock */
> > +        spin_unlock(&pdc_lock);   /* DEBUG code freaks out here. */
> >  }
> 
> I thought we agreed this should become
> 
> if(spin_is_locked(&pdc_lock))
> 	spin_unlock(&pdc_lock);

sorry - I misunderstood. My  bad.
Let me commit a spin_is_locked() implementation instead.
I'd prefer that too.

grant