[parisc-linux-cvs] Re: 2.4.19-pa16 DIFF fix circular dependency

[Matthew Wilcox]

On Fri, Sep 13, 2002 at 05:11:34PM -0600, Grant Grundler wrote:
> I've posted this diff before and basically got no feedback on it.

hrm, i don't remember it.

> It works for me. The most questionable part is the change
> in fs_struct.h.

> +#include <linux/config.h>
> +
> +#include <asm/atomic.h>
> +#ifdef CONFIG_SMP
> +#include <asm/spinlock.h>
> +#endif
> +

Yeah, this is just not right.  You shouldn't conditionalise inclusion
on CONFIG_SMP.  And you should include <linux/foo.h> if it exists,
which it does for spinlock.h.  It doesn't for atomic.h, so there's
nothing wrog with that.

-- 
Revolutions do not require corporate support.