[parisc-linux-cvs] linux tsbogend

[Grant Grundler]

Matthew Wilcox wrote:
> It's additional complexity when we can do better by reducing complexity.

I agree your patch reduces complexity...but I'd like to hear it works.
Since neither of us has a dino based machine for testing ATM, can someone
try this patch for us?

I'm interested in B132, B160, C100, C180, C200 or similar machine results.

> actually, my primary concern is rearchitecting this code.  most of it was
> written without a strategy in mind.

hmmm...that's not a fair assesment. bus_devices stuff was only intended
to support LASI. I thought it could be used to support dino auxilary
devices as well.  This was all before rbrad and yourself implemented
the PA devices IO tree.  The I/O Tree will obsolete many of the things
we've done. Perhaps bus_devices support can completely go away in the
future or change to use the IO tree like dino does.

> here's a diff which is actually a slight improvement on what i'd done
> before.  i'm not in a position to test this right now, but i hope it's
> obvious what i'm doing.

It wasn't until you explained fixup_child_irqs() initializes IRQ values
for dino's "children" (serial and PS/2). Those "children" are only
present when PDC tells us about them and we depend on PDC to only provide
pseudo entries for usable devices. I really hope this works as it shows
how the IO Tree is useful for more than just DMA services.

thanks!
grant