[parisc-linux-cvs] diff for 2.4.17-pa25

[Grant Grundler]

"Brian S. Julin" wrote:
> This is my first commit, so please do complain if I've done anything at
> all wrong.

Commit was well done overall...thanks for posting the diff.
I was griping about how stupid mh is (can't handle Mime)
but that's a local issuee...


+       /* For now we are ignoring these until we get the SDC to behave. */
+       if (((status & 0xf1) == 0x51) && data == 0x82) {
+         return;
+       }

This could read :
	/* FIXME: Ignore WTF_IS_51 and WTF_IS_82 until driver more stable */
	if (((status & 0xf1) == 0x51) && data == 0x82)
		return;

+       // printk("\n>[%2.2x,%2.2x] (%lu) ", status, data, mfctl(16));

I prefer to keep something like this in my drivers:

#undefine DEBUG_SBA_INIT

#ifdef DEBUG_SBA_INIT
#define DBG_INIT(x...)  printk(x)
#else
#define DBG_INIT(x...)
#endif

and later:
	DBG_INIT("SBA at 0x%p\n", hpa);


Then you don't need the silly C++ comments and anyone can enable
your debug code properly.

'nuf nit picking for now...thanks!

grant