[parisc-linux-cvs] linux deller

Grant Grundler grundler@dsl2.external.hp.com
Sat, 02 Feb 2002 17:56:01 -0700


Helge Deller wrote:
> -		printk(KERN_ERR __FUNCTION__ ": cannot get GSC irq\n");
> +		printk(KERN_ERR "%s(): cannot get GSC irq\n", __FUNCTION__);

Helge,
thanks for fixing these warnings!

In general, I now only use __FUNCTION__ in macros. I used to
use __FUNCTION__ alot because I was lazy and just copied printk
lines from one function to where ever I needed it.

In this case, You may as well embed the function name in the output
string since it's not changing. Unless you have something else
to fix in the file (or just want to), I'd leave your change alone.

thanks,
grant