[parisc-linux-cvs] Re: DIFF 2.4.19-pa2 update 0.92 acenic.c

[Grant Grundler]

Matthew Wilcox wrote:
> > +#if LINUX_VERSION_CODE < 0x2051e
> > +#define local_irq_save(flags)		do{__save_flags(flags) ; \
> > +					   __cli();} while(0)
> > +#define local_irq_restore(flags)	__restore_flags(flags)
> > +#endif
> > +
> 
> this is just wrong.  in 2.4.9, we have:
> 
> #define local_irq_restore(x)    __restore_flags(x)

Now I understand your question about warning vs error.
If a macro is redefined with a different value, it's a warning.
If it's redefined with the same value, no warning or error.

All arches in 2.4.0 except ia64 define local_irq_restore() the same way.
His code would produce warnings on ia64 and certainly not link.

> in asm-i386/system.h.  so the version code check should
> probably be for 20400.

yeah - another fix for 0.93 in addition to using pci_enable_device(). ;^)

grant