[parisc-linux-cvs] build w/o CONFIG_GSC_PS2 ?

Richard Hirst rhirst@linuxcare.com
Tue, 9 Oct 2001 10:36:52 +0100


On Tue, Oct 09, 2001 at 12:59:36AM -0600, Grant Grundler wrote:
> 
> Following patch let me build a 64-bit kernel for A500.
> Don't (shouldn't) need CONFIG_GSC_PS2.
> Comments?
> 
> grant
> 
> Index: drivers/char/Makefile
> ===================================================================
> RCS file: /home/cvs/parisc/linux/drivers/char/Makefile,v
> retrieving revision 1.21
> diff -u -p -r1.21 Makefile
> --- Makefile	2001/08/01 15:25:08	1.21
> +++ Makefile	2001/10/09 06:54:38
> @@ -73,6 +73,10 @@ endif
>  
>  ifdef CONFIG_GSC_PS2
>    KEYBD   = hp_psaux.o hp_keyb.o
> +else
> +ifdef CONFIG_PARISC
> +  KEYBD   =
> +endif
>  endif
>  
>  ifeq ($(ARCH),arm)

Looks reasonable to me, although I think the following (untested) code
fits better with the style of the makefile:

ifeq ($(ARCH),parisc)
  ifeq ($(CONFIG_GSC_PS2),y)
    KEYBD   = hp_psaux.o hp_keyb.o
  else
    KEYBD   =
  endif
endif


Richard