[parisc-linux-cvs] 64-bit cleanup for the sim700 driver.

[Grant Grundler]

Richard Hirst wrote:
...
> Most of the /4 in my local source are Ent_xxx/4, where all Ent_xxx
> come from the script compiler output.  In fact, in my source there
> are only two occurances of /sizeof(u32).  Personally I'd make those
> /4 and leave it at that.

Me too.
I didn't realize how much of the code comes from the script compiler.

...
> So, Grants proposed change is wrong because it doesn't do a
> /sizeof(u32).  The original code has an implied /sizeof(u32) because
> it is taking the difference of two (u32 *).

Ah ok. I did overlook the implied ptr arithmetic. Maybe getting rid of
the implied math would be a Good Thing (tm) since I wasn't the only one.


> Try the following if you like:
> 
> index = (NCR_read32(DSP_REG) - low32(targdata->ba->script))/sizeof(u32);

Or '/4' ?
 ;^)

...
> Yes, nice work Grant - obviously got too much time to kill down
> there on the beach ;)

Thanks - Yes. :^)
But I'm mostly trying to return the favor to rbrad.
He thoroughly reviewed my code too (sba_iommu.c mostly).

grant

Grant Grundler
parisc-linux {PCI|IOMMU|SMP} hacker
+1.408.447.7253