[parisc-linux-cvs] [PATCH] 32-bit PDC wrapper patch

Matthew Wilcox matthew@wil.cx
Thu, 15 Mar 2001 20:30:46 +0000

On Thu, Mar 15, 2001 at 10:57:48AM -0700, Paul Bame wrote:
> I like this too, and had it not been for STI and some other "rogue"
> uses of mem_pdc_call(), I'd have preferred to have mem_pdc_call()
> and the rest of the type-unsafe stuff, safely hidden in pdc.c like
> you suggest, or at least have a separate "private" header file if we
> keep real1.c around (which might be a good idea for STI and possibly
> a PDC ioctl() call in the future).

mem_pdc_call isn't used by the STI console -- it calls real32_call
directly.  I suspect that's a bug, because no-one's tried STI console
on a 64-bit machine yet.

> The current situation has the callers to the pdc_ layer knowing
> way too much IMO (like alignment and sometimes phys/virt I think).

Yeah.  Since pdc_ isn't speed critical, i suspect we should allocate
some target buffers which are aligned correctly for PDC and then copy
them back (as necessary; at least one caller of pdc_iodc_read ignores
the iodc_data buffer).

Revolutions do not require corporate support.