[parisc-linux-cvs] [PATCH] 32-bit PDC wrapper patch

Matthew Wilcox matthew@wil.cx
Thu, 15 Mar 2001 17:39:23 +0000


On Thu, Mar 15, 2001 at 10:31:54AM -0700, Paul Bame wrote:
> = Here's a proposed (I hope) simplification.  feedback welcome, as ever.
> = > +	return mem_pdc_call(PDC_ARG2_IS_NOT_RADDR, PDC_CHASSIS, PDC_CHASSIS_DIS
> P, disp);
> = 	return mem_pdc_call3(PDC_CHASSIS, PDC_CHASSIS_DISP, disp);
> 
> mem_pdc_call3() would still have to know whether or not to translate ARG2
> as an RADDR.  This suggested design change may have significant
> ramifications to real1.c and possibly real2.S.

[i'll reply to the rest in a moment]

you overlooked the next function where I explicitly translated the arg2.
I feel this is cleaner than telling the called function whether or not
to translate it.

-- 
Revolutions do not require corporate support.