[parisc-linux-cvs] cleanups...

Grant Grundler grundler@puffin.external.hp.com
Sat, 23 Jun 2001 15:42:10 -0600


Helge Deller wrote:
...
> Index: drivers/gsc/dino.c
> ===================================================================
> RCS file: /home/cvs/parisc/linux/drivers/gsc/dino.c,v
> retrieving revision 1.28
> diff -u -r1.28 dino.c
> --- dino.c	2001/06/14 09:50:22	1.28
> +++ dino.c	2001/06/20 20:02:41
> @@ -827,7 +827,7 @@
>  	struct busdevice *dino_busdevice;
>  	int ret;
>  
> -	pcibios_register_hba((struct pci_hba_data *) dino_dev);
> +	pcibios_register_hba(&dino_dev->hba);

I was going to complain this change was wrong but just
realized they are equivalent. "hba" field *must* be the
first field in the PCI bridge specific driver struct.
Both dino and elroy drivers make that assumption at least
when they gets passed in a "pci_hba_data *". So don't
panic if you look at the lba_pci.c code...

grant

Grant Grundler
parisc-linux {PCI|IOMMU|SMP} hacker
+1.408.447.7253