[parisc-linux-cvs] Cujo support & Serial cleanups

[Matthew Wilcox]

On Tue, Aug 28, 2001 at 11:15:45AM +0100, Richard Hirst wrote:
> On Tue, Aug 28, 2001 at 12:49:46AM +0100, Matthew Wilcox wrote:
> > On Tue, Aug 28, 2001 at 12:42:10AM +0100, Richard Hirst wrote:
> > > I trust that doesn't reintroduce all those problems of serial ports
> > > being discovered in the wrong order...
> > 
> > Er... if that's why we had all those duplicate entries, there should at
> > least have been a comment by them!  But I can't see how that would be the
> > case.  The code does:
> > 
> > register_parisc_driver()
> > 	for_each_device {
> > 		if (!match_device(driver, device))
> > 			continue;
> > 	}
> > 
> > and this shouldn't change whether we match or not.
> 
> It isn't an issue of whether we match or not, it is a question of what
> order we match in. We used to have problems with ttyS0 and ttyS1
> being reversed, and those entries were added to resolve that.  There
> shouldn't have been any duplicate entries, there should have been a
> bunch of explicit entries for ports we know about, followed by a couple
> of non-specific entries as a catch-all to pick up anything else.
> 
> Could your new device discovery code have fixed this problem in a
> different way, I wonder?

Maybe.  Or maybe it broke it and nobody noticed yet.  Could someone who
had this problem previously let us know if it's affecting them now?

-- 
Revolutions do not require corporate support.