[parisc-linux-cvs] 2.4.7 tulip fix

Richard Hirst rhirst@linuxcare.com
Wed, 1 Aug 2001 21:01:16 +0100


patch-2.4.8-pre3.bz2 from Linus already fixed this by simply removing
the pad.  tulip_core.c requires at least 16 bit alignment, so I'd say
an aligned attr is needed.  I chose 8 based on the old comment.

Richard


On Wed, Aug 01, 2001 at 08:50:18PM +0100, Richard Hirst wrote:
> The pad was forcing dev_addr to offset 0xb1, as MAX_ADDR_LEN was changed
> from 7 to 8.
> 
> --- netdevice.h 2001/08/01 15:27:24     1.9
> +++ netdevice.h 2001/08/01 19:42:09
> @@ -298,8 +298,7 @@
>  
>         /* Interface address info. */
>         unsigned char           broadcast[MAX_ADDR_LEN];        /* hw bcast add */
> -       unsigned char           pad;            /* make dev_addr aligned to 8 bytes */
> -       unsigned char           dev_addr[MAX_ADDR_LEN]; /* hw address   */
> +       unsigned char           dev_addr[MAX_ADDR_LEN] __attribute__((aligned(8)));     /* hw address   */
>         unsigned char           addr_len;       /* hardware address length      */
>  
>         struct dev_mc_list      *mc_list;       /* Multicast mac addresses      */
> 
> 
> 
> _______________________________________________
> parisc-linux-cvs mailing list
> parisc-linux-cvs@lists.parisc-linux.org
> http://lists.parisc-linux.org/cgi-bin/mailman/listinfo/parisc-linux-cvs
>